RFR: 8327647: Occasional SIGSEGV in markWord::displaced_mark_helper() for SPECjvm2008 sunflow [v5]
Matias Saavedra Silva
matsaave at openjdk.org
Tue Apr 30 16:06:12 UTC 2024
On Fri, 26 Apr 2024 21:04:39 GMT, Dean Long <dlong at openjdk.org> wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Removed empty line
>
> OK, except for the "another thread" part. The reads are done in the current thread, so that's the thread the barrier is for.
>
> // Prevents stale data from being read after the bytecode is patched to the fast bytecode
Thank you for the reviews and detailed discussion @dean-long @coleenp @sunny868 @RealFYang!
I think it is best to move forward with the current design. If we do find that the unneeded LoadLoad negatively impacts performance, I will follow up with an appropriate fix.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18477#issuecomment-2085778675
More information about the hotspot-compiler-dev
mailing list