RFR: 8331185: Enable compiler memory limits in debug builds [v2]
Thomas Stuefe
stuefe at openjdk.org
Tue Apr 30 16:16:09 UTC 2024
On Mon, 29 Apr 2024 18:30:30 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Opened a bug to track the memory limit break in compiler/loopopts/TestDeepGraphVerifyIterativeGVN.java. Since I cannot reproduce it, someone at Oracle should look at this: https://bugs.openjdk.org/browse/JDK-8331295
>
>> Thank you, @tstuefe, for filing these bugs.
>>
>> One additional thing I noticed is that we don't produce compilation replay file (its size is 0) for such failures. Can you look why is that?
>
> Yes, its https://bugs.openjdk.org/browse/JDK-8331344 . I'll post a PR shortly.
>
> The problem behind this is more generic, namely that producing replay files needs resource area, and it shouldn't. We should not allocate resource area or heap in fatal error handling. But for now, I'll fix this locally by avoiding the recursion.
> > > Thank you, @tstuefe, for filing these bugs.
> > > One additional thing I noticed is that we don't produce compilation replay file (its size is 0) for such failures. Can you look why is that?
> >
> >
> > Yes, its https://bugs.openjdk.org/browse/JDK-8331344 . I'll post a PR shortly.
> > The problem behind this is more generic, namely that producing replay files needs resource area, and it shouldn't. We should not allocate resource area or heap in fatal error handling. But for now, I'll fix this locally by avoiding the recursion.
>
> Good. I think we need to push it before this PR.
@vnkozlov Openend PR: https://github.com/openjdk/jdk/pull/19005
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18969#issuecomment-2085824934
More information about the hotspot-compiler-dev
mailing list