RFR: 8330247: C2: CTW fail with assert(adr_t->is_known_instance_field()) failed: instance required [v3]

[Vladimir Kozlov]

On Mon, 29 Apr 2024 21:19:33 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:

>> The logic in reduce allocation merges (RAM) makes use of `PhaseMacroExpand:;can_eliminate_allocation` to check whether an allocation can be scalar replaced. However, we can only SR allocations of exact types - due to rematerialization logic.
>> 
>> The scalar replacement logic not related to RAM has this check in `split_unique_types` so there is no performance regression by adding this check here.
>> 
>> Tested on Linux x64 tiers1-3.
>
> Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix formatting.

My testing passed.

-------------

Marked as reviewed by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18851#pullrequestreview-2031942526