RFR: 8334060: Implementation of Late Barrier Expansion for G1 [v2]

[Roberto Castañeda Lozano]

On Sat, 29 Jun 2024 03:51:29 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> make/hotspot/gensrc/GensrcAdlc.gmk line 205:
>> 
>>> 203:   ifeq ($(call check-jvm-feature, g1gc), true)
>>> 204:     AD_SRC_FILES += $(call uniq, $(wildcard $(foreach d, $(AD_SRC_ROOTS), \
>>> 205:         $d/cpu/$(HOTSPOT_TARGET_CPU_ARCH)/gc/g1/g1_$(HOTSPOT_TARGET_CPU).ad \
>> 
>> on s390, `g1_s390.ad` file is not compiled with current code. 
>> 
>> Suggestion:
>> 
>>         $d/cpu/$(HOTSPOT_TARGET_CPU_ARCH)/gc/g1/g1_$(HOTSPOT_TARGET_CPU_ARCH).ad \
>
> I guess this one might be better:
> 
> diff --git a/make/hotspot/gensrc/GensrcAdlc.gmk b/make/hotspot/gensrc/GensrcAdlc.gmk
> index e34f0725397..ef9c15b2975 100644
> --- a/make/hotspot/gensrc/GensrcAdlc.gmk
> +++ b/make/hotspot/gensrc/GensrcAdlc.gmk
> @@ -203,6 +203,7 @@ ifeq ($(call check-jvm-feature, compiler2), true)
>    ifeq ($(call check-jvm-feature, g1gc), true)
>      AD_SRC_FILES += $(call uniq, $(wildcard $(foreach d, $(AD_SRC_ROOTS), \
>          $d/cpu/$(HOTSPOT_TARGET_CPU_ARCH)/gc/g1/g1_$(HOTSPOT_TARGET_CPU).ad \
> +        $d/cpu/$(HOTSPOT_TARGET_CPU_ARCH)/gc/g1/g1_$(HOTSPOT_TARGET_CPU_ARCH).ad \
>        )))
>    endif
> 
> 
> Build is fine with both changes, (tested on Mac-M1)

Thanks! I went with the second option (commit 47079ea1) for consistency with other collectors.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19746#discussion_r1709781421