RFR: 8338112: Test testlibrary_tests/ir_framework/tests/TestPrivilegedMode.java fails with release build [v3]

Tobias Hartmann thartmann at openjdk.org
Mon Aug 12 05:08:31 UTC 2024


On Fri, 9 Aug 2024 14:50:03 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>>  The testcase `testlibrary_tests/ir_framework/tests/TestPrivilegedMode.java` fails with release build, the test log snippet says `IR verification disabled due to not running a debug build`. So I think it's need `@requires vm.debug == true`. And ths test will fail without c2 compiler, so it also need `@requires vm.compiler2.enabled`.
>> 
>> The change has been verified with linux x64 release build and linux x64 fastdebug build, no risk,
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   delete vm.compMode != "Xint"

Looks good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20524#pullrequestreview-2232052022


More information about the hotspot-compiler-dev mailing list