RFR: 8338156: Fix -Wzero-as-null-pointer-constant warnings in jvmciCompilerToVM.cpp
Thomas Schatzl
tschatzl at openjdk.org
Mon Aug 12 07:40:30 UTC 2024
On Mon, 12 Aug 2024 07:16:34 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
> Please review this change to remove -Wzero-as-null-pointer-constant warnings
> in jvmciCompilerToVM.cpp. We're changing uses of _0 suffixed exception macros
> to instead use the corresponding _NULL suffixed macros where appropriate.
>
> Testing: mach5 tier1
Marked as reviewed by tschatzl (Reviewer).
src/hotspot/share/jvmci/jvmciCompilerToVM.cpp line 553:
> 551: if (!klass->is_interface()) {
> 552: THROW_MSG_NULL(vmSymbols::java_lang_IllegalArgumentException(),
> 553: err_msg("Expected interface type, got %s", klass->external_name()));
Unlike in the other cases, the indentation has not been updated. Looks good otherwise.
-------------
PR Review: https://git.openjdk.org/jdk/pull/20538#pullrequestreview-2232240694
PR Review Comment: https://git.openjdk.org/jdk/pull/20538#discussion_r1713292066
More information about the hotspot-compiler-dev
mailing list