RFR: 8338124: C2 SuperWord: MulAddS2I input permutation still partially broken after JDK-8333840

Tue Aug 13 05:56:03 UTC 2024

On Mon, 12 Aug 2024 17:18:20 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> [JDK-8333840](https://bugs.openjdk.org/browse/JDK-8333840) attempted to fix some input permutation cases. Sadly, there is a typo which means that there can still be some broken cases that produce wrong results.
>> 
>> `MulAddS2I` is a special case, where we have to verify that the 4 inputs for all members of the pack are in the same permutation. I only started the checking on the second element. This worked on all my previous examples, but does not work on the added regression test. We must, of course, start the checking on the first element.
>
> Good.

Thanks for the reviews @vnkozlov @chhagedorn @TobiHartmann !

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20539#issuecomment-2285389821