RFR: 8338156: Fix -Wzero-as-null-pointer-constant warnings in jvmciCompilerToVM.cpp [v2]

Kim Barrett kbarrett at openjdk.org
Tue Aug 13 05:56:16 UTC 2024


On Mon, 12 Aug 2024 07:38:12 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix indent in jvmciCompilerToVM.cpp
>
> src/hotspot/share/jvmci/jvmciCompilerToVM.cpp line 553:
> 
>> 551:   if (!klass->is_interface()) {
>> 552:     THROW_MSG_NULL(vmSymbols::java_lang_IllegalArgumentException(),
>> 553:         err_msg("Expected interface type, got %s", klass->external_name()));
> 
> Unlike in the other cases, the indentation has not been updated. Looks good otherwise.

In other cases I was maintaining pre-existing alignment.  Here it was already formatted differently, and I
thought this was a file that used this indentation style (not that I like it).  But looking around, I'm not
finding other uses of this style, so I've aligned the arguments.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20538#discussion_r1714703715


More information about the hotspot-compiler-dev mailing list