RFR: 8338158: Cleanup ShouldNotXXX uses in machnode.cpp

[Christian Hagedorn]

On Tue, 13 Aug 2024 06:34:50 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> > Looks good! Just a general question, will you update `fatal()` uses in a separate RFE?
> 
> I'm not planning to. There are lots and lots of these sorts of things for ShouldNotXXX, fatal(), &etc. I only did these because I was touching some to eliminate -Wzero-as-null-pointer-constant warnings, and there were few enough it was still a relatively small change. Also there was already inconstency of usage in this one file. I suggest just similarly cleaning these up as code is being touched for other reasons.

Sounds good, thanks for sharing some details!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20540#issuecomment-2285479162