RFR: 8325467: Support methods with many arguments in C2 [v2]

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Tue Aug 20 09:46:24 UTC 2024


On Tue, 20 Aug 2024 09:30:33 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> I have investigated using a `GrowableArray` now, including a discussion with people involved in their development. Currently, there are some limitations with `GrowableArray` that have a negative performance impact for our use case:
>> - There is no efficient copy/clone operation.
>> - `GrowableArray` construction currently default-initializes everything within their capacity, which is unnecessary in our case (and probably unnecessary in general as well).
>> 
>> Yes, one option is to implement the above for `GrowableArray`. There is, however, already an ongoing discussion on how to best do this, and there are some pitfalls. I prefer to not start a more general and largely orthogonal discussion on `GrowableArray` changes here and suggest we update my current manual allocation to use a `GrowableArray` in a separate RFE, after `GrowableArray` has the required functionality.
>
> Fair enough, thanks for investigating!

Maybe you can add a comment above the definition of `_RM_UP_EXT` motivating your choice, based on what you found.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20404#discussion_r1723014204


More information about the hotspot-compiler-dev mailing list