RFR: 8325467: Support methods with many arguments in C2 [v2]

Daniel Lundén dlunden at openjdk.org
Tue Aug 20 14:05:53 UTC 2024


On Tue, 20 Aug 2024 07:20:37 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove leftover CHUNK_SIZE reference
>
> src/hotspot/share/opto/regmask.hpp line 144:
> 
>> 142: 
>> 143:   // Return a suitable arena for (extended) register mask allocation.
>> 144:   static Arena* _get_arena();
> 
> Maybe inline this function into its only user?

I would like to, but that results in a cyclic header inclusion problem between `regmask.hpp` and `compile.hpp`. It could maybe be solved, but it doesn't look trivial. Putting the definition in `regmask.cpp` seems like the simplest solution, but I'm open to suggestions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20404#discussion_r1723377552


More information about the hotspot-compiler-dev mailing list