RFR: 8325467: Support methods with many arguments in C2 [v3]

[Daniel Lundén]

On Tue, 20 Aug 2024 13:16:32 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add can_represent asserts
>
> src/hotspot/share/opto/regmask.hpp line 362:
> 
>> 360:   // Verify watermarks are sane, i.e., within bounds and that no
>> 361:   // register words below or above the watermarks have bits set.
>> 362:   bool valid_watermarks() const {
> 
> For sanity, should we also assert here, and enforce across the code, that `_lwm <= _hwm`, even in the case of `Size() == 0` or is this invariant too expensive/difficult to maintain?

We could do that, but I'm not sure I see the benefit. Could you elaborate a bit?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20404#discussion_r1723415718