RFR: 8325467: Support methods with many arguments in C2 [v2]
Daniel Lundén
dlunden at openjdk.org
Tue Aug 20 14:34:53 UTC 2024
On Tue, 20 Aug 2024 09:41:14 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove leftover CHUNK_SIZE reference
>
> src/hotspot/share/opto/regmask.hpp line 120:
>
>> 118: // and between the two marks can still be 0.
>> 119: unsigned int _lwm;
>> 120: unsigned int _hwm;
>
> It seems `_hwm` does not take `_all_stack` into account, i.e. it is perfectly legal to have a register mask with `_hwm < _rm_max && _all_stack = true`. I think it would be worth noting it in a code comment.
Now incorporated as part of the nice diagram that you contributed!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20404#discussion_r1723426887
More information about the hotspot-compiler-dev
mailing list