RFR: 8336830: C2: assert(get_loop(lca)->_nest < n_loop->_nest || lca->in(0)->is_NeverBranch()) failed: must not be moved into inner loop [v2]

Roland Westrelin roland at openjdk.org
Thu Aug 22 15:09:19 UTC 2024


On Tue, 30 Jul 2024 16:52:31 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> src/hotspot/share/opto/loopopts.cpp line 1275:
>> 
>>> 1273:   for (;;) {
>>> 1274:     Node* dom = idom(useblock);
>>> 1275:     if (loop->is_member(get_loop(dom))) {
>> 
>> This would not be backported, right? Do you think we should do it in a separate RFE? Or is it necessary for the fix?
>
> Yes, it should be separate RFE  or you back port [JDK-8335709](https://bugs.openjdk.org/browse/JDK-8335709) first.

Right. That makes sense. I removed it in latest commit and will create a separate PR for it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20334#discussion_r1727259517


More information about the hotspot-compiler-dev mailing list