RFR: 8335444: Generalize implementation of AndNode mul_ring [v3]

[Jasmine Karthikeyan]

On Mon, 19 Aug 2024 11:18:04 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Jasmine Karthikeyan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Check IR before macro expansion
>
> src/hotspot/share/opto/mulnode.cpp line 611:
> 
>> 609:   if (r0->_lo >= 0 && r1->_lo >= 0) {
>> 610:     return IntegerType::make(0, MIN2(r0->_hi, r1->_hi), widen);
>> 611:   }
> 
> Since you've already worked out the math in the PR comment, do you also want to add it here to the different cases? It could help to support the correctness of the code.

I agree, I think it would be good to include the math in the code to make it easier to understand. I'll add it in the next commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20066#discussion_r1727774283