RFR: 8325467: Support methods with many arguments in C2 [v4]

Daniel Lundén dlunden at openjdk.org
Fri Aug 23 11:17:07 UTC 2024


On Wed, 21 Aug 2024 23:55:15 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update after Roberto's comments and suggestions
>
> src/hotspot/share/adlc/formsopt.cpp line 368:
> 
>> 366:     fprintf(fp," 0x%x,", regs_in_word(i, false));
>> 367:   }
>> 368:   fprintf(fp," 0x%x );\n", regs_in_word(i, false));
> 
> Does use of RegMask_Size() above for the length still make sense?  IIUC, RegMask_Size() is what previously determined the max size of frames and register masks.

`RegMask_Size()` [determines](https://github.com/dlunde/jdk/blob/953966686ef7b86972bb2c156c931c60c4e5cb70/src/hotspot/share/adlc/output_h.cpp#L101) the base, statically allocated, chunk for register masks. If I'm not mistaken, it does not affect max frame size. The "all-stack" bit of current register masks already allows frame growth beyond what a register mask can represent.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20404#discussion_r1728804110


More information about the hotspot-compiler-dev mailing list