RFR: 8325467: Support methods with many arguments in C2 [v3]
Daniel Lundén
dlunden at openjdk.org
Fri Aug 23 11:17:08 UTC 2024
On Tue, 20 Aug 2024 16:34:40 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
>> We could do that, but I'm not sure I see the benefit. Could you elaborate a bit?
>
> The benefit, in my opinion, is better comprehensibility due to a simpler model with stronger invariants. An alternative would be to extend the comment at the definition of `_lwm` and `_hwm` clarifying that the value of these variables is unspecified when the register set is empty.
Recapping what we discussed in-person here: we should not try to enforce `_lwm <= _hwm`, but describe how they work and what they guarantee in more detail through comments in `regmask.hpp`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20404#discussion_r1728806664
More information about the hotspot-compiler-dev
mailing list