RFR: 8333258: C2: high memory usage in PhaseCFG::insert_anti_dependences()

[Roland Westrelin]

On Tue, 23 Jul 2024 16:18:26 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

> Hmm. Personally I'd rather have something more vague than misleading. Maybe it could be `store -> use_mem_state` and `mem -> def_mem_state`? I guess that is then a bit wordy. Up to you.

I went with that. Thanks for the suggestion.

> > The assert is on loop entry. There's a if between the new assert and the condition that was removed but the if block ends with a continue. So the assert is guaranteed to be executed every time the removed was executed.
> 
> I understand, and agree on a technical level. Someone in the future may break things, and that is why I would prefer the assert to be there. But up to you.

The assert on loop entry is executed more often (and on every element of the queue) than if it was where you recommend it to be which is why I'd like to leave it there.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19791#issuecomment-2310183296