RFR: 8334060: Implementation of Late Barrier Expansion for G1 [v2]
Roberto Castañeda Lozano
rcastanedalo at openjdk.org
Mon Aug 26 13:26:07 UTC 2024
On Mon, 26 Aug 2024 09:42:29 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
> That one is among the failing tests. Can we agree on better names than g1XChgP and g1XChgN? They are not readable very well IMHO.
Sure, I agree that `g1GetAndSetP` and `g1GetAndSetN` are more consistent with the corresponding Ideal operation names, will rename the instructions in x64 and aarch64 and update the test expectations.
> Regardless if you implement the compressed oops optimization or not, I'd reconsider moving the oop decoding into G1BarrierSetAssembler::g1_write_barrier_post_c2 because it makes the .ad file shorter because you can get rid of the replicated decode_heap_oop.
Thanks, will try it out.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19746#discussion_r1731240303
More information about the hotspot-compiler-dev
mailing list