RFR: 8333258: C2: high memory usage in PhaseCFG::insert_anti_dependences() [v3]

Roland Westrelin roland at openjdk.org
Mon Aug 26 13:34:42 UTC 2024


On Tue, 23 Jul 2024 16:20:23 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

> But I would like you to fix the comments here:
> 
> ```
>   // The relevant stores "nearby" the load consist of a tree rooted
>   // at initial_mem, with internal nodes of type MergeMem.
>   // Therefore, the branches visited by the worklist are of this form:
>   //    initial_mem -> (MergeMem ->)* store
>   // The anti-dependence constraints apply only to the fringe of this tree.
> ```
> 
> There are not just `MergeMem` but also `Phi` nodes.

I updated the comment. Does that look better to you?

@eme64 can you have a look at the updated change?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19791#issuecomment-2310224862
PR Comment: https://git.openjdk.org/jdk/pull/19791#issuecomment-2310225420


More information about the hotspot-compiler-dev mailing list