RFR: 8321010: RISC-V: C2 RoundVF [v15]
Hamlin Li
mli at openjdk.org
Wed Aug 28 10:29:59 UTC 2024
On Wed, 28 Aug 2024 09:31:52 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:
>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>>
>> minor
>
> src/hotspot/cpu/riscv/riscv.ad line 1916:
>
>> 1914: return UseRVV && MaxVectorSize >= 32;
>> 1915: case Op_RoundVD:
>> 1916: return UseRVV && MaxVectorSize >= 64;
>
> It would be worth leaving the same comment you've in the PR description here as well, to make it very clear in the sources why the option is enable/disabled on these parameters.
Added comments. Thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17745#discussion_r1734407261
More information about the hotspot-compiler-dev
mailing list