RFR: JDK-8332423 : [PPC64] Remove C1_MacroAssembler::call_c_with_frame_resize [v5]

Martin Doerr mdoerr at openjdk.org
Wed Aug 28 20:19:24 UTC 2024


On Wed, 28 Aug 2024 06:54:57 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>> JBS Issue : [JDK-8332423](https://bugs.openjdk.org/browse/JDK-8332423)
>> C1_MacroAssembler::call_c_with_frame_resize is only used with frame_resize == 0. 
>> Also, call_c is adapted as per endianess of system. 
>> We can adapt the exisiting code to handle the endianness check at one place and not have to repeatedly check at multiple places to make calls to call_c.
>
> Suchismith Roy has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - review comments
>  - review comments

LGTM. Thanks for the update!

One more thing: `C1_MacroAssembler::call_c_with_frame_resize` should be removed completely.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19947#pullrequestreview-2267182675
Changes requested by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19947#pullrequestreview-2267186515


More information about the hotspot-compiler-dev mailing list