RFR: 8334060: Implementation of Late Barrier Expansion for G1 [v2]
Roberto Castañeda Lozano
rcastanedalo at openjdk.org
Thu Aug 29 09:11:23 UTC 2024
On Thu, 29 Aug 2024 08:37:24 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Thanks, I prototyped the refactored version for both x64 and aarch64 [here](https://github.com/robcasloz/jdk/commit/c1ae871eadac0d44981b7892ac8f7b64e8734283). I do not have a strong opinion for or against this refactoring. @albertnetymk @kimbarrett what do you think about it? (asking since you have recently looked at this code).
>
> I find the use of default-arg-value `bool decode_new_val = false` a bit confusing. (I tend to think default-arg-value makes the code less readable in general.)
>
> If not using default-arg-value, I suspect the diff will be larger, and I don't see the immediate benefit of this refactoring. Maybe this can be deferred to its own PR if it's really desirable?
Thanks for looking at it, Albert! Since there is no clear consensus, let's postpone the refactoring. We can come back to it after the JEP is integrated if there is renewed interest.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19746#discussion_r1735852561
More information about the hotspot-compiler-dev
mailing list