RFR: 8334060: Implementation of Late Barrier Expansion for G1 [v9]

[Roberto Castañeda Lozano]

On Sun, 25 Aug 2024 01:53:30 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Roberto Castañeda Lozano has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Pass oldval to the pre-barrier in g1CompareAndExchange/SwapP
>
> src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.cpp line 218:
> 
>> 216:     __ cbz(new_val, done);
>> 217:   }
>> 218:   // Storing region crossing non-null, is card already dirty?
> 
> s/already dirty/young/

Done (commit [70c2771](https://github.com/openjdk/jdk/pull/19746/commits/70c2771818834a74a12f8a61de3c77bb69e3e531)), thanks.

> src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.cpp line 280:
> 
>> 278: 
>> 279: #undef __
>> 280: #define __ masm->
> 
> These "changes" to `__` are unnecessary and confusing.  We have the same define near the top of
> the file, unconditionally.  This one is conditonal on COMPILER2, but is left in place at the end of the
> conditional block, affecting following unconditional code.

Removed now (commit [2dc688b](https://github.com/openjdk/jdk/pull/19746/commits/2dc688baf2a8f446c7579fafce7eab3a953e623a)), thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19746#discussion_r1738181093
PR Review Comment: https://git.openjdk.org/jdk/pull/19746#discussion_r1738182128