RFR: 8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5
Dean Long
dlong at openjdk.org
Fri Aug 30 23:54:18 UTC 2024
On Fri, 30 Aug 2024 17:28:16 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> The change in [JDK-8335664](https://bugs.openjdk.org/browse/JDK-8335664) caused a crash when initializing basic blocks with `-Xcomp`. This change introduces a check to see if JSR is the last bytecode in its method so that expected behavior matches the previous patch. Verified with tier 1-6 tests.
>
> test/hotspot/jtreg/runtime/interpreter/LastJsrTest.java line 39:
>
>> 37: public class LastJsrTest {
>> 38: public static void main(String[] args) {
>> 39: for (int i = 0; i < 1000; ++i) {
>
> Don't you need 10,000 in your loop to trigger compilation?
Yes for C2, but this is enough for C1, the only compiler that needs this fix. I wanted to make sure C1 compilation was triggered by default without -Xcomp. Testing tiers that use -Xcomp will make sure it passes with C2.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20732#discussion_r1739532956
More information about the hotspot-compiler-dev
mailing list