RFR: 8330159: [C2] Remove or clarify Compile::init_start [v3]

[Dean Long]

On Thu, 29 Aug 2024 11:23:50 GMT, Yagmur Eren <duke at openjdk.org> wrote:

>> Compile::init_start method contained only an assertion. To cleanup, this method is removed and the locations where this method is called are replaced with the corresponding assertion. See issue: [JDK-8330159](https://bugs.openjdk.org/browse/JDK-8330159)
>
> Yagmur Eren has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove method header

src/hotspot/share/opto/generateOptoStub.cpp line 264:

> 262:                                           returnadr());
> 263:   root()->add_req(_gvn.transform(to_exc));  // bind to root to keep live
> 264:   DEBUG_ONLY(C->verify_start(start);)

This looks fine, but instead of marking every call site with DEBUG_ONLY, how about adding NOT_DEBUG_RETURN to the declaration of verify_start(), so it is a no-op in non-debug builds?  For an example, see check_no_dead_use().

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20715#discussion_r1739548132