RFR: 8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5

[Vladimir Kozlov]

On Tue, 27 Aug 2024 18:01:16 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> The change in [JDK-8335664](https://bugs.openjdk.org/browse/JDK-8335664) caused a crash when initializing basic blocks with `-Xcomp`. This change introduces a check to see if JSR is the last bytecode in its method so that expected behavior matches the previous patch. Verified with tier 1-6 tests.

src/hotspot/share/compiler/methodLiveness.cpp line 227:

> 225: 
> 226:           if (bci + Bytecodes::length_for(code) >= method_len) break;
> 227: 

Please, use code style which use `{}` and put body on separate line as you did in `c1_GraphBuilder.cpp`
You will not need empty lines around it then.

src/hotspot/share/compiler/methodLiveness.cpp line 240:

> 238: 
> 239:           if (bci + Bytecodes::length_for(code) >= method_len) break;
> 240: 

Same here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20732#discussion_r1739554607
PR Review Comment: https://git.openjdk.org/jdk/pull/20732#discussion_r1739554749