RFR: 8345158: IGV: local scheduling should not place successors before predecessors

Mon Dec 2 14:05:38 UTC 2024

On Mon, 2 Dec 2024 12:58:57 GMT, Daniel Skantz <duke at openjdk.org> wrote:

> A slight tweak to consider def-use in scheduleBlock.
> 
> Testing: opened a few graphs in control-flow graph mode without any assertion failure.

Looks good, thanks for fixing this Daniel!

I tested this by examining a few schedules manually (comparing IGV-approximated schedules after matching vs. "real" C2-generated schedules after GCM) and also checked that the changes do not increase the overhead of approximating schedules in IGV (which is still negligible compared to graph layout time).

-------------

Marked as reviewed by rcastanedalo (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22481#pullrequestreview-2472789707