RFR: 8332268: C2: Add missing optimizations for UDivI/L and UModI/L and unify the shared logic with the signed nodes [v17]
theoweidmannoracle
duke at openjdk.org
Mon Dec 2 16:38:03 UTC 2024
On Mon, 2 Dec 2024 10:21:38 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Looks good to me otherwise. Nice tests!
>
> Ok. I'm not sure about the Template vs BasicType. Generally BasicType is what we have used so far, but I would say Templates are cleaner. Discussed it with @TobiHartmann , and he thinks Templates are fine too.
>
> But you need to move the `make_...` to the corresponding file, so others can find it.
>
> And I think the constants in the tests should be given as `1L << 42`, and not some long unreadable chain of digits ;)
Thanks for all your comments, @eme64. I think I addressed them all.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22061#issuecomment-2512071345
More information about the hotspot-compiler-dev
mailing list