RFR: 8344304: [s390x] ubsan: negation of -2147483648 cannot be represented in type 'int' [v2]

[Dean Long]

On Sat, 30 Nov 2024 03:10:33 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> fixes the issue reported by ubsan.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   cover lir_add as well

src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp line 1540:

> 1538:                       } else {
> 1539:                         __ z_afi(lreg, c);
> 1540:                       }

It seems like it would be better to have code like this in a helper function, instead of making every call site repeat the pattern.  Can you use add2reg() here?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22456#discussion_r1866779410