RFR: 8344304: [s390x] ubsan: negation of -2147483648 cannot be represented in type 'int' [v4]

[Lutz Schmidt]

On Tue, 3 Dec 2024 09:13:15 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> fixes the issue reported by ubsan.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   move logic to add2reg_32 & use java_negate()

Changes requested by lucy (Reviewer).

src/hotspot/cpu/s390/macroAssembler_s390.cpp line 683:

> 681:   z_agfi(r1, imm);
> 682: }
> 683: 

I would prefer this method to have the same interface as add2reg(). Of course, that implies a more complex method body. Your choice.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22456#pullrequestreview-2475248982
PR Review Comment: https://git.openjdk.org/jdk/pull/22456#discussion_r1867472345