RFR: 8344304: [s390x] ubsan: negation of -2147483648 cannot be represented in type 'int' [v5]

[Dean Long]

On Tue, 3 Dec 2024 11:34:19 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> fixes the issue reported by ubsan.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   make similar to add2reg

src/hotspot/cpu/s390/macroAssembler_s390.hpp line 160:

> 158:   // Generic operation r1 := r2 + imm.
> 159:   void add2reg   (Register r1, int64_t imm, Register r2 = noreg);
> 160:   void add2reg_32(Register r1, int64_t imm, Register r2 = noreg);

I don't understand the difference between these two.  For both, imm must be a simm_32.  I don't think we need add2reg_32.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22456#discussion_r1867585614