RFR: 8345156: C2: Add bailouts next to a few asserts

[Daniel Skantz]

On Mon, 2 Dec 2024 19:34:18 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> This patch associates product bailouts with a few existing debug asserts. The criteria are that there have been product bugs associated with failing these asserts in the past, and that there are not too many callers to the method where the compilation is now cancelled or any measurable impact on compilation time.
>> 
>> Testing: T1-T4 and extra testing. Tested compilation time with -XX:+CITime on performance benchmarks and the effect was not measurable.
>
> src/hotspot/share/opto/gcm.cpp line 1535:
> 
>> 1533:       // defs in new LCA block.
>> 1534:       LCA = insert_anti_dependences(LCA, self);
>> 1535:       if (C->failing()) {
> 
> Same here. I don't see where `record_failure()` is called from `insert_anti_dependences()`.
> And there are a lot of assets there.

This is intended to cover `insert_anti_dependences` : `memory_early_block` : `assert_dom` : `record_failure("unschedulable graph");`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22482#discussion_r1867749958