RFR: 8343747: C2: TestReplicateAtConv.java crashes with -XX:MaxVectorSize=8

Emanuel Peter epeter at openjdk.org
Tue Dec 3 16:38:41 UTC 2024


On Tue, 3 Dec 2024 16:27:48 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Crash occurs when attempting to create a `Replicate` node that's input
>> to a `VectorCast` node (for a `ConvL2I`) that's not supported by the
>> platform (when run with `MaxVectorSize=8`). I think the pack for the
>> `VectorCast` should be filtered out earlier as not implemented and I
>> propose adding a test to `VectorCastNode::implemented()` for the type
>> of its input to handle that corner case.
>
> test/hotspot/jtreg/compiler/vectorization/TestReplicateAtConv.java line 29:
> 
>> 27:  * @summary C2 compilation fails with "bad AD file" due to Replicate
>> 28:  * @run main/othervm -XX:CompileCommand=compileonly,TestReplicateAtConv::test -Xcomp TestReplicateAtConv
>> 29:  * @run main/othervm -XX:CompileCommand=compileonly,TestReplicateAtConv::test -Xcomp -XX:MaxVectorSize=8 TestReplicateAtConv
> 
> You should add the new bug id to the test.

Maybe you should also update the summary, and say that the issue is about replicate and cast.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22442#discussion_r1868047222


More information about the hotspot-compiler-dev mailing list