Integrated: 8340141: C1: rework ciMethod::equals following 8338471
Dean Long
dlong at openjdk.org
Tue Dec 3 17:08:54 UTC 2024
On Tue, 24 Sep 2024 00:35:47 GMT, Dean Long <dlong at openjdk.org> wrote:
> This PR changes ciMethod::equals() to a special-purpose debug helper method for the one place in C1 that uses it in an assert. The reason why making it general purpose is difficult is because JVMTI can add and delete methods. See the bug report and JDK-8338471 for more details. I'm open to suggestions for a better name than equals_ignore_version().
>
> An alternative approach, which I think may actually be better, would be to check for old methods first, and bail out if we see any. Then we can change the assert back to how it was originally, using ==.
This pull request has now been integrated.
Changeset: 293323c3
Author: Dean Long <dlong at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/293323c3e210bc2a3e45a0a9bc99b55378be91d2
Stats: 40 lines in 3 files changed: 21 ins; 18 del; 1 mod
8340141: C1: rework ciMethod::equals following 8338471
Reviewed-by: kvn, vlivanov
-------------
PR: https://git.openjdk.org/jdk/pull/21148
More information about the hotspot-compiler-dev
mailing list