RFR: 8345219: C2: x86_64 should not go to interpreter stubs for NaNs handling
Emanuel Peter
epeter at openjdk.org
Wed Dec 4 07:05:40 UTC 2024
On Tue, 3 Dec 2024 07:10:16 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> This fix looks correct by looking on original changes.
>>
>> Yes, special Interpreter's code for these methods is only generated for x86_32 in `templateInterpreterGenerator_x86_32.cpp`.
>
>> This fix looks correct by looking on original changes.
>
> Thank you! I need one more (R)eviewer :)
@shipilev Generally looks reasonable, though I'm not very familiar with this part of the code.
One question: Could we add an IR test that would show that no interpreter stubs are emitted, but instead whatever it is now emitting?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22446#issuecomment-2516362667
More information about the hotspot-compiler-dev
mailing list