RFR: 8341293: Split field loads through Nested Phis [v2]

[Emanuel Peter]

On Wed, 4 Dec 2024 07:55:05 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Dhamoder Nalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   CR feedback
>
> test/hotspot/jtreg/compiler/c2/irTests/scalarReplacement/AllocationMergesNestedPhiTests.java line 34:
> 
>> 32:  * @summary Tests that C2 can correctly scalar replace some object allocation merges.
>> 33:  * @library /test/lib /
>> 34:  * @requires vm.debug == true & vm.flagless & vm.bits == 64 & vm.compiler2.enabled & vm.opt.final.EliminateAllocations
> 
> Do you need all of these? Or is it just that IR rules are failing otherwise?
> If it is just about the IR rules, you can restrict IR rules with `applyIf...`

Generally it is nice if tests can run on as many platforms, compilers and flags as possible. But of course IR rules can only apply under specific circumstances.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21270#discussion_r1868897981