RFR: 8345159: RISCV: Fix -Wzero-as-null-pointer-constant warning in emit_static_call_stub
Hamlin Li
mli at openjdk.org
Wed Dec 4 09:14:44 UTC 2024
On Wed, 4 Dec 2024 08:57:00 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> When looking at the disassembly it much easier to find uninitialized call stubs when we use 0.
>> Also if something would go wrong, it much nicer with a crash than a loop.
>> So for debuggability I prefer address 0.
>
> I'm inclined to leave this as is, because I agree with @robehn and because I think directly calling movptr2
> when that's what one needs to have called (because one expected a particular sequence of instructions
> to be generated) is better than indirectly calling it via the more generic movptr. Anyone disagree? I'll wait
> another day for responses.
I agree with a straight `0`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22435#discussion_r1869025747
More information about the hotspot-compiler-dev
mailing list