RFR: 8345471: Clean up compiler/intrinsics/sha/cli tests
Daniel Jeliński
djelinski at openjdk.org
Wed Dec 4 10:16:14 UTC 2024
Merge all the GenericTestCaseForUnsupportedXXXCPU and GenericTestCaseForOtherCPU into GenericTestCaseForUnsupportedCPU.java.
The CPU-specific files are almost identical; I chose to resolve the differences in favor of the AArch64 version. The OtherCPU version looks wrong, and it wasn't executed on any supported platform.
The tests continue to pass on linux-aarch64/x64, windows-x64 and mac-aarch64. I didn't test other platforms.
After the change, the tests will start running on PPC and S390. They will also automatically run on any new architectures.
For those interested in historical background, when the tests were introduced, there were only 2 supported CPU architectures. X86 did not support any of the intrinsics, and the X86 test case did not even call `getPredicateForOption`. The call to `getPredicateForOption` was added in f2e9b827d699115f8683e9def06c249e5476fd50, and since then all the cases are the same.
-------------
Commit messages:
- Unify GenericTestCaseForUnsupportedCPU
Changes: https://git.openjdk.org/jdk/pull/22517/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22517&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8345471
Stats: 628 lines in 11 files changed: 114 ins; 497 del; 17 mod
Patch: https://git.openjdk.org/jdk/pull/22517.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/22517/head:pull/22517
PR: https://git.openjdk.org/jdk/pull/22517
More information about the hotspot-compiler-dev
mailing list