RFR: 8345299: C2: some nodes can still have incorrect control after do_range_check() [v2]

Vladimir Kozlov kvn at openjdk.org
Wed Dec 4 18:03:44 UTC 2024


On Wed, 4 Dec 2024 15:15:39 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> src/hotspot/share/opto/loopTransform.cpp line 2825:
>> 
>>> 2823:   // new main_limit can push Bool/Cmp nodes down (when one of the eliminated condition has parameters that are not loop
>>> 2824:   // invariant in the pre loop).
>>> 2825:   set_ctrl(opqzm, new_limit_ctrl);
>> 
>> Update this comment too.
>
> Both done in new commit. Do the comments look ok to you?

yes

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22485#discussion_r1870036054


More information about the hotspot-compiler-dev mailing list