RFR: 8345700: tier{1, 2, 3}_compiler don't cover all compiler tests

Aleksey Shipilev shade at openjdk.org
Mon Dec 9 08:20:37 UTC 2024


On Fri, 6 Dec 2024 20:10:08 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> Hi, 
> could you please review following fix that update
> tier3_compiler test group
> so :hotspot_compiler is always a sum of
> tier1_compiler, tier2_compiler, tier3_compiler
> This is natural splitting of tests into 3 layers. 
> The fix is done to execution :hotspot_compiler into 3 tiers with corresponding group names.
> 
> New tests in tier3:
> 9 tests in compiler/ccp/
> 22 test in ompiler/predicates/
> 8 tests in compiler/splitif/
> So the number is not increased significantly.
> 
> The new group
> ` tier2_ctw`
> was introduced for ctw testing. 
> It is different from tests in hotspot_compiler, and usually executed separately, So I added it as separate sub-test of tier2.
> 
> I moved ctw from tier3 to tier2 to correspond current tiers of Hotspot CI in our system. 
> If anyone thinks it should be part of tier3 - we can discuss in PR comments how do deal with it.
> 
> @shipilev, could you please take a look and check if these changes are ok to you since you the author of tier2/tier3.

A good test for these changes is looking at GHA usages and see how well the tests are balanced between the groups. See for example here: https://github.com/lmesnik/jdk/actions/runs/12205347403/usage. I am not sure if this is pre-existing or not, but it looks like `hs/tier1 compiler part 3` is twice as long as `part 1` or `part 2`. We would ideally like all parts to take roughly the same time.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22614#issuecomment-2527231121


More information about the hotspot-compiler-dev mailing list