RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v6]

[Emanuel Peter]

On Mon, 9 Dec 2024 07:37:55 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add comment, extract cast into local variable
>
> src/hotspot/cpu/x86/x86.ad line 2215:
> 
>> 2213: 
>> 2214: // Return true if Vector::rearrange needs preparation of the shuffle argument
>> 2215: bool Matcher::vector_needs_load_shuffle(BasicType elem_bt, int vlen) {
> 
> I commented on this before. This needs to have a more expressive name. Is it just about rearrange? Because now it sounds like maybe all vectors may need a shuffle. Or just all loads? Confusing.

Maybe it coud be named `vector_rearrange_requires_load_shuffle`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21042#discussion_r1875542286