RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v8]

[Quan Anh Mai]

On Tue, 10 Dec 2024 09:02:40 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> This is called in an `assert` so I think throwing `AssertionError` seems more reasonable, the original implementation also throws `AssertionError`
>
> I see, you want to throw an error here and not just use an assert statement that reports an assertion failure with -ea flag.  This is a newly added routine, why don't you simply return a false and let the assertion invoking this routine do the rest?

This routine is moved from `AbstractShuffle` where it was implemented when all shuffle types share the same constructor  there. Throwing here allows easier construction of the error message.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21042#discussion_r1878383065