RFR: 8345700: tier{1, 2, 3}_compiler don't cover all compiler tests [v2]
Aleksey Shipilev
shade at openjdk.org
Tue Dec 10 16:23:43 UTC 2024
On Tue, 10 Dec 2024 15:43:01 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
>> Hi,
>> could you please review following fix that update
>> tier3_compiler test group
>> so :hotspot_compiler is always a sum of
>> tier1_compiler, tier2_compiler, tier3_compiler
>> This is natural splitting of tests into 3 layers.
>> The fix is done to execution :hotspot_compiler into 3 tiers with corresponding group names.
>>
>> New tests in tier3:
>> 9 tests in compiler/ccp/
>> 22 test in ompiler/predicates/
>> 8 tests in compiler/splitif/
>> So the number is not increased significantly.
>>
>> The new group
>> ` tier2_ctw`
>> was introduced for ctw testing.
>> It is different from tests in hotspot_compiler, and usually executed separately, So I added it as separate sub-test of tier2.
>>
>> I moved ctw from tier3 to tier2 to correspond current tiers of Hotspot CI in our system.
>> If anyone thinks it should be part of tier3 - we can discuss in PR comments how do deal with it.
>>
>> @shipilev, could you please take a look and check if these changes are ok to you since you the author of tier2/tier3.
>
> Leonid Mesnik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>
> - Merge branch 'master' of https://github.com/openjdk/jdk into 8345700
> - 8345700: tier{1,2,3}_compiler doesn't cover all compiler tests
Looks fine, assuming GHA turns out green.
-------------
Marked as reviewed by shade (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22614#pullrequestreview-2492859848
More information about the hotspot-compiler-dev
mailing list