RFR: 8344026: Ubsan: prevent potential integer overflow in c1_LIRGenerator_<arch>.cpp file [v8]

[Tobias Hartmann]

On Wed, 4 Dec 2024 10:19:56 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> Ok, I forgot that unsigned has properly defined overflow semantics.
>> 
>>> No, as of now I only ran tier1 test cases with c1 compiler. Nothing else.
>> 
>> Tests would really be great. Is that possible?
>
>> Tests would really be great. Is that possible?
> 
> I could try, Wouldn't this be already tested by `test/hotspot/jtreg/compiler/c1/MultiplyByMaxInt.java` and `test/hotspot/jtreg/compiler/integerArithmetic/MultiplyByIntegerMinHang.java` tests :)

Shouldn't we get an incorrect result with these tests then?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22144#discussion_r1879434649