RFR: 8344026: Ubsan: prevent potential integer overflow in c1_LIRGenerator_<arch>.cpp file [v8]

Emanuel Peter epeter at openjdk.org
Wed Dec 11 07:11:40 UTC 2024


On Wed, 11 Dec 2024 07:07:13 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> Shouldn't we get an incorrect result with these tests then?
>
>> Shouldn't we get an incorrect result with these tests then?
> 
> I don't see any failures, again why would there be an incorrect result ? I didn't get that.

Is this just undefined behaviour, but no compiler so far actually does something unexpected? If so, it will be impossible to have a failing regression test before the patch. But if there is actually an overflow bug, then there could be a regression test that would be failing before the patch, and we should try to find it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22144#discussion_r1879462868


More information about the hotspot-compiler-dev mailing list