RFR: 8341696: C2: Non-fluid StringBuilder pattern bails out in OptoStringConcat [v3]

[Emanuel Peter]

On Wed, 11 Dec 2024 07:20:23 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> theoweidmannoracle has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move test
>
> test/hotspot/jtreg/compiler/stringopts/TestFluidAndNonFluid.java line 68:
> 
>> 66:     public static String fluidNoParam() {
>> 67:         return new StringBuilder("0").append("a").append("c").toString();
>> 68:     }
> 
> Drive by comment: you seem to only have negative `failOn` tests here. You could consider adding a test where you have a positive rule, just to make sure you are matching the correct IR nodes.

Never mind, I did not see the positive cases below 🙈

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22537#discussion_r1879654644