RFR: 8345609: [C1] LIR Operations with one input should be implemented as LIR_Op1 [v2]

[Goetz Lindenmaier]

On Thu, 5 Dec 2024 17:17:18 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update Copyright headers.
>
> src/hotspot/share/c1/c1_LIR.cpp line 492:
> 
>> 490:       assert(op1->_info != nullptr, "");  do_info(op1->_info);
>> 491:       if (op1->_opr->is_valid())       do_temp(op1->_opr); // safepoints on SPARC need temporary register
>> 492:       assert(op1->_tmp->is_illegal(), "not used");
> 
> I think safepoints should ideally be implemented as LIR_Op0. SPARC support is removed. We could file a new RFE for that.

Well, a grep showed there are more leftovers of sparc and solaris in hotspot, but not a matter of this change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22582#discussion_r1880119999