RFR: 8332827: [REDO] C2: crash in compiled code because of dependency on removed range check CastIIs [v2]

Roland Westrelin roland at openjdk.org
Wed Dec 11 15:36:51 UTC 2024


> The failures that caused the backout were due to a bug in:
> 
> `find_or_make_integer_cast()`
> 
> which caused the `_range_check_dependency` field's value of the
> existing cast node to not be set in the new cast node. I re-ran some
> testing with this fixed and current jdk repo and found that a few
> vectorization tests fail now because the patch pushes range check
> `CastII` nodes through `AddI`/`SubI`. To fix this, I delayed that
> transformation to after loop opts.

Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Merge branch 'master' into JDK-8332827
 - review
 - white spaces
 - test & fix
 - Revert "8332829: [BACKOUT] C2: crash in compiled code because of dependency on removed range check CastIIs"
   
   This reverts commit c9a7b9772d96d9a4825d9da2aacc277534282860.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22568/files
  - new: https://git.openjdk.org/jdk/pull/22568/files/ea75615a..85a9155a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22568&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22568&range=00-01

  Stats: 85871 lines in 1694 files changed: 69383 ins; 11236 del; 5252 mod
  Patch: https://git.openjdk.org/jdk/pull/22568.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22568/head:pull/22568

PR: https://git.openjdk.org/jdk/pull/22568


More information about the hotspot-compiler-dev mailing list