Integrated: 8342651: Refactor array constant to use an array of jbyte
Quan Anh Mai
qamai at openjdk.org
Wed Dec 11 16:02:20 UTC 2024
On Sun, 20 Oct 2024 11:39:24 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:
> Hi,
>
> This small patch refactors array constants in C2 to use an array of `jbyte`s instead of an array of `jvalue`. The former is much easier to work with and we can do `memcpy` with them trivially.
>
> Since code buffers support alignment of the constant section, I have also allowed constant tables to be aligned more than 8 bytes and used it for constant vectors on machines not supporting `SSE3`. I also fixed an issue with code buffer relocation where the temporary buffer is not correctly aligned.
>
> This patch is extracted from https://github.com/openjdk/jdk/pull/21229. Tests passed with `UseSSE=2` where 16-byte constants would be generated, as well as normal testing routines.
>
> Please take a look and leave your reviews, thanks a lot.
This pull request has now been integrated.
Changeset: 2c4567a6
Author: Quan Anh Mai <qamai at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/2c4567a689091721476b6ef0ef4ad042fd63c3fd
Stats: 176 lines in 8 files changed: 77 ins; 44 del; 55 mod
8342651: Refactor array constant to use an array of jbyte
Reviewed-by: thartmann, kvn
-------------
PR: https://git.openjdk.org/jdk/pull/21596
More information about the hotspot-compiler-dev
mailing list